Re: libargp ready for reviewing

On Sat, Mar 11, 2006 at 03:29:45PM +0100, Thomas Klausner wrote:
> X-Original-To: [email protected]
> Delivered-To: [email protected]
> From: Thomas Klausner <[email protected]>
> To: Lubomir Kundrak <[email protected]>
> Cc: [email protected]
> Subject: Re: libargp ready for reviewing
> Mail-Followup-To: Lubomir Kundrak <[email protected]>,
> 	[email protected]
> In-Reply-To: <[email protected]>
> X-Spam-Score: 0.0 (/)
> X-Spam-Report: Spam Filtering performed by sourceforge.net.
> 	See http://spamassassin.org/tag/ for more details.
> 	Report problems to http://sf.net/tracker/?func=add&group_id=1&atid=200001
> Errors-To: [email protected]
> X-BeenThere: [email protected]
> X-Mailman-Version: 2.0.9-sf.net
> Precedence: bulk
> List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review>,
> 	<mailto:[email protected]?subject=unsubscribe>
> List-Id: (requests for) package reviews and comments <pkgsrc-wip-review.lists.sourceforge.net>
> List-Post: <mailto:[email protected]>
> List-Help: <mailto:[email protected]?subject=help>
> List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review>,
> 	<mailto:[email protected]?subject=subscribe>
> List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum=pkgsrc-wip-review>
> Date: Sat, 11 Mar 2006 15:29:45 +0100
> X-Spam-Score: 0.0 (/)
> X-Spam-Report: Spam Filtering performed by sourceforge.net.
> 	See http://spamassassin.org/tag/ for more details.
> 	Report problems to http://sf.net/tracker/?func=add&group_id=1&atid=200001
> 
> On Thu, Mar 09, 2006 at 03:55:25PM +0100, Lubomir Kundrak wrote:
> > Please review if package is ok, and if libargp is a suitable name for
> > it.
> 
> patch-aa looks slightly wrong:
>  #ifndef __THROW
> -# define __THROW
> +#undef __THROW
>  #endif
>  
> +#define __THROW
> +
> 
> I guess you mean '#ifdef' at the top?

Yes, you're right. I fixed it.

> 
> The package name is ok.
>  Thomas
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by xPML, a groundbreaking scripting language
> that extends applications into web and mobile media. Attend the live webcast
> and join the prime developer group breaking into this new coding territory!
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
> _______________________________________________
> pkgsrc-wip-review mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review

-- 
  o	Lubomir Kundrak
 *O*	<[email protected]>, http://skosi.org/~lkundrak/
 (_)	SKOSI -- Slovak OpenSource Initiative


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642