Re: Seeking reviews of wip/oak

On Sat, Mar 11, 2006 at 06:20PM +0100, Thomas Klausner wrote:
>CONF_FILES should point to PKG_SYSCONFDIR as target.
>Of course, the program should be fixed to look for its config
>file(s) there too.

  Oak reads the config file location as a command line argument.  The 
  rc.d/oak script I created was already using PKG_SYSCONFDIR, so should be 
  good to go.

>I'd prefer
>	${INSTALL_DATA_DIR} ${PREFIX}/share/examples/oak
>to the INSTALLATION_DIRS line.

  Curious: why the preference? Seems like that's what INSTALLATION_DIRS was 
  made for.  I'm guessing there may be certain limitations on what 
  INSTALLATION_DIRS can do?

>patch-ab, ac: use sizeof(buffer)-1 instead of the hardwired sizes
>in the strncpy, and NUL-terminate the buffers manually. Or use
>strlcpy.

  Fixed.

>patch-ad: you could put the file in files/ and install it in
>the post-install step too -- that'd make editing it easier

  Seems reasonable given the manpage is not a part of the stock source tree.
  Done.

>(I have some ideas on how to improve it).

  Fire away.

Thanks,
-Jason

-- 
Jason White <[email protected]>       Jabber: jdwhite(jabber.org)
http://www.jdwhite.org/~jdwhite                 jason.d.white(gmail.com)
PGP KeyID: 0x5290E477


-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642