Re: Please review wip/dtach
Francis GUDIN <[email protected]>
| Newsgroups | gmane.os.netbsd.devel.pkgsrc.wip.review |
|---|---|
| Message-ID | <20060617114222.GA844@escapebox> |
Hello, On Friday, 16 June 2006 at 14:06:29 -0700, Min Sik Kim wrote : > > 1. PLIST is incomplete. Please run 'make print-PLIST > PLIST' after > installing the package. > > 2. MASTER_SITES should include the directory name. See print/latex- > mk for example. > > 3. The URL in DESCR is not necessary in pkgsrc because Makefile has > HOMEPAGE. > > 4. Remove the unused FreeBSD CVS Id from Makefile. > > 5. The variable name "PORTDOCS" is misleading. Maybe just "DOCS"? Thank you ! I fixed all issues, hopefully. Best regards, -- Francis GUDIN <[email protected]> Fingerprint 305E 15CF A53E 14E0 6ACE 8CED C5D5 5A78 15E3 6AB2 A Declaration of the Independence of Cyberspace: http://homes.eff.org/~barlow/Declaration-Final.html _______________________________________________ pkgsrc-wip-review mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/pkgsrc-wip-review
signature.asc
(application/pgp-signature, 191 B)
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.2 (DragonFly) iD8DBQFEk+qdxdVaeBXjarIRAlCOAJ4+fWrmmFvQcTN3D9Z61LEPTmnWdACbBybw lgm/93eo3HG5FyZYxLZVUgM= =syFl -----END PGP SIGNATURE-----