Re: New Package for review: Faban
Thomas Klausner <[email protected]>
| Newsgroups | gmane.os.netbsd.devel.pkgsrc.wip.review |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Sep 05, 2006 at 06:05:10PM +0100, Cherry G.Mathew wrote: > Could you please review this package ? > > ftp://ftp.netbsd.org/pub/NetBSD/misc/cherry/pkgsrc/ pkglint has comments: WARN: PLIST:64: .orig files should not be in the PLIST. WARN: PLIST:67: .orig files should not be in the PLIST. WARN: patches/patch-aa:10: Found absolute pathname: /usr/pkg/java/sun-1.5/ WARN: patches/patch-ab:10: Found absolute pathname: /usr/pkg/java/sun-1.5 This should use the Java framework in pkgsrc. See mk/java-vm.mk. And adapt the patches for that. Probably use SUBST_* instead. Having a tree for the faban files is not "nice". Is there a way to split these files up in the standard locations and keeping it working? You should set PKGNAME, otherwise it will be installed as "faban-bundle". Cheers, Thomas ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642