Re: please review wip/postoffice
"Jeremy C. Reed" <[email protected]>
| Newsgroups | gmane.os.netbsd.devel.pkgsrc.wip.review |
|---|---|
| Message-ID | <[email protected]> |
I didn't test your package, but I have comments :)
For readability, use tabs (or spacing) to line up the make variable
values.
I think this should be handled automatically:
INSTALLATION_DIRS+=${PREFIX}/share/examples/rc.d
Use SYSCONFBASE instead of hard-coded /etc.
Use VARBASE instead of /var.
Maybe remove my old comment from pop_passwd.pl :)
Spell check DESCR.
In MESSAGE remove note about copying postoffice.cf. That can be handled
with CONF_FILES.
The PLIST has a bunch of man pages but no corresponding tools listed in
PLIST. Check this?
If so, CONFLICT with other mail packages that provide same filenames.
In rc.d script don't hard-code "/usr/pkg" and "/var" and "/etc".
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV