Re: [PATCH 1/3] gcc: Add missing parentheses around ternary operator

Martin Husemann <[email protected]>
Newsgroups gmane.os.netbsd.devel.toolchain,gmane.os.netbsd.devel.userlevel
Message-ID <[email protected]>
On Sun, Aug 29, 2021 at 01:42:22PM +1000, Damien Zammit wrote:
> --- a/external/gpl3/gcc/dist/libcpp/files.c
> +++ b/external/gpl3/gcc/dist/libcpp/files.c
> @@ -233,7 +233,7 @@ open_file (_cpp_file *file)
>      }
>    else
>      file->fd = open (file->path, O_RDONLY | O_NOCTTY | O_BINARY
> -		     | (cpp_restricted != NULL) ? O_NONBLOCK : 0, 0666);
> +		     | ((cpp_restricted != NULL) ? O_NONBLOCK : 0), 0666);

This is something we would prfer to go via upstream gcc, has it been
reported there? If we bring in a temporary local fix, we usually note
a reference to the upstrem commit or bug report.

Martin
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.