Re: [PATCH 1/3] gcc: Add missing parentheses around ternary operator
David Holland <[email protected]>
| Newsgroups | gmane.os.netbsd.devel.toolchain |
|---|---|
| Message-ID | <[email protected]> |
On Sun, Sep 05, 2021 at 05:55:04PM +0700, Robert Elz wrote: > | I mean, the other reason it's harmless is that O_NOCTTY doesn't > | actually do anything. > > Oh, that I didn't know ... and I admit to not bothering to check. > I just assumed that if a process with no controlling tty opened a > tty device with that flag set, that terminal wouldn't become its > controlling tty. > > If we don't implement that, is there any reason? Yeah, as you see it's the default. I don't remember the details any more, or whether it was a bsd vs. sysv thing or what, but AFAICR the other open behavior where it's needed was old and basically deprecated even in the 90s. > ps; I am aware it is not a POSIX defined flag. I thought the reason we had it at all is that it _is_ in POSIX... -- David A. Holland [email protected]