[PATCH] Current GNU libc: Declare htonl() via <arpa/inet.h> for hppa mkboot

Jan-Benedict Glaw <[email protected]> Mon, 28 Oct 2024 21:15:41 +0100
Newsgroups gmane.os.netbsd.devel.toolchain
Message-ID <[email protected]>
Hi!

Another issue with hppa:


[bld tls 2024-10-19 12:41:01] echo '#  ' "compile " hppa-mkboot/mkboot.lo
[bld tls 2024-10-19 12:41:01] + echo #   compile  hppa-mkboot/mkboot.lo
[bld tls 2024-10-19 12:41:01] #   compile  hppa-mkboot/mkboot.lo
[bld tls 2024-10-19 12:41:01] cc -O   -I/var/lib/laminar/run/netbsd-hppa-hppa/48/NetBSD-src/tools/hppa-mkboot -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -I/var/lib/laminar/run/netbsd-hppa-hppa/48/tools-hppa-hppa/include/compat -I/var/lib/laminar/run/netbsd-hppa-hppa/48/NetBSD-src/tools/compat -DHAVE_NBTOOL_CONFIG_H=1 -D_FILE_OFFSET_BITS=64 -I/var/lib/laminar/run/netbsd-hppa-hppa/48/NetBSD-src/external/gpl3/binutils/dist/include -DATTRIBUTE_PACKED= -c -o mkboot.lo.o    /var/lib/laminar/run/netbsd-hppa-hppa/48/NetBSD-src/tools/hppa-mkboot/../../sys/arch/hppa/stand/mkboot/mkboot.c
[bld tls 2024-10-19 12:41:01] + cc -O -I/var/lib/laminar/run/netbsd-hppa-hppa/48/NetBSD-src/tools/hppa-mkboot -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -I/var/lib/laminar/run/netbsd-hppa-hppa/48/tools-hppa-hppa/include/compat -I/var/lib/laminar/run/netbsd-hppa-hppa/48/NetBSD-src/tools/compat -DHAVE_NBTOOL_CONFIG_H=1 -D_FILE_OFFSET_BITS=64 -I/var/lib/laminar/run/netbsd-hppa-hppa/48/NetBSD-src/external/gpl3/binutils/dist/include -DATTRIBUTE_PACKED= -c -o mkboot.lo.o /var/lib/laminar/run/netbsd-hppa-hppa/48/NetBSD-src/tools/hppa-mkboot/../../sys/arch/hppa/stand/mkboot/mkboot.c
[bld tls 2024-10-19 12:41:01] /var/lib/laminar/run/netbsd-hppa-hppa/48/NetBSD-src/tools/hppa-mkboot/../../sys/arch/hppa/stand/mkboot/mkboot.c: In function 'putfile':
[bld tls 2024-10-19 12:41:01] /var/lib/laminar/run/netbsd-hppa-hppa/48/NetBSD-src/tools/hppa-mkboot/../../sys/arch/hppa/stand/mkboot/mkboot.c:104:6: error: implicit declaration of function 'ntohl' [-Wimplicit-function-declaration]
[bld tls 2024-10-19 12:41:01]   104 |     (ntohl((uint32_t)((ex).a_midmag))&0xffff) : ((ex).a_midmag))
[bld tls 2024-10-19 12:41:01]       |      ^~~~~
[bld tls 2024-10-19 12:41:01] /var/lib/laminar/run/netbsd-hppa-hppa/48/NetBSD-src/tools/hppa-mkboot/../../sys/arch/hppa/stand/mkboot/mkboot.c:252:13: note: in expansion of macro 'N_GETMAGIC'
[bld tls 2024-10-19 12:41:01]   252 |         if (N_GETMAGIC(ex) == OMAGIC || N_GETMAGIC(ex) == NMAGIC)
[bld tls 2024-10-19 12:41:01]       |             ^~~~~~~~~~
[bld tls 2024-10-19 12:41:01] 
[bld tls 2024-10-19 12:41:01] *** Failed target:  mkboot.lo
[bld tls 2024-10-19 12:41:01] *** Failed command: cc -O -I/var/lib/laminar/run/netbsd-hppa-hppa/48/NetBSD-src/tools/hppa-mkboot -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -I/var/lib/laminar/run/netbsd-hppa-hppa/48/tools-hppa-hppa/include/compat -I/var/lib/laminar/run/netbsd-hppa-hppa/48/NetBSD-src/tools/compat -DHAVE_NBTOOL_CONFIG_H=1 -D_FILE_OFFSET_BITS=64 -I/var/lib/laminar/run/netbsd-hppa-hppa/48/NetBSD-src/external/gpl3/binutils/dist/include -DATTRIBUTE_PACKED= -c -o mkboot.lo.o /var/lib/laminar/run/netbsd-hppa-hppa/48/NetBSD-src/tools/hppa-mkboot/../../sys/arch/hppa/stand/mkboot/mkboot.c
[bld tls 2024-10-19 12:41:01] *** Error code 1
[bld tls 2024-10-19 12:41:01] 
[bld tls 2024-10-19 12:41:01] Stop.



index 2ffd375cf482..4c2601964ba1 100644
--- a/sys/arch/hppa/stand/mkboot/mkboot.c
+++ b/sys/arch/hppa/stand/mkboot/mkboot.c
@@ -52,6 +52,7 @@ static char rcsid[] = "$OpenBSD: mkboot.c,v 1.9 2001/05/17 00:57:55 pvalchev Exp
 #include <sys/bootblock.h>
 #endif
 
+#include <arpa/inet.h>
 #include <sys/param.h>
 #include <sys/file.h>
 #include <sys/stat.h>



Thanks,
  Jan-Benedict

--
signature.asc (application/pgp-signature, 195 B)
-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQQlDTvPcScNjKREqWEdvV51g5nhuwUCZx/w6QAKCRAdvV51g5nh
u2DWAKCCd0DtYRfmL2a/kHm3hU7buozedACfYFddQAUUGrRLhkxzrPd3FwfD9dM=
=7Ckj
-----END PGP SIGNATURE-----