Re: CVS commit: src/external/bsd/libarchive/dist/libarchive

On Fri, Aug 21, 2026 at 10:12:25PM +0100, Taylor R Campbell wrote:
> Module Name:	src
> Committed By:	riastradh
> Date:		Fri Aug 21 22:12:25 UTC 2026
> 
> Modified Files:
> 	src/external/bsd/libarchive/dist/libarchive: archive_string.c
> 
> Log Message:
> libarchive: Patch iconv() use to handle POSIX semantics.
> 
> Previously it assumed nonstandard GNU semantics, causing tests to
> fail on NetBSD:
> 
> /usr/src/external/bsd/libarchive/dist/libarchive/test/test_archive_string_conversion.c:950:
> -1 != r
>       -1=-1 (0xffffffffffffffff, 01777777777777777777777)
>       r=0 (0x0, 00)
> /usr/src/external/bsd/libarchive/dist/libarchive/test/test_archive_string_conversion.c:951:
> 0 != mstr.aes_set & AES_SET_MBS
>       0=0 (0x0, 00)
>       mstr.aes_set & AES_SET_MBS=1 (0x1, 01)
> 
> Upstream bug report:
> Issue #3413: test_archive_string_conversion_fail_c failure despite
> correct iconv(3)
> https://github.com/libarchive/libarchive/issues/3413
> 
> Patch proposed upstream:
> Pull request #3416: Treat non-identical conversions in iconv as
> failure.
> https://github.com/libarchive/libarchive/pull/3416
> 
> PR lib/60560: libarchive tests are failing

A userland from August 19 was fine, but one from today is not, so I
suspect this commit to cause an extraction error for
pkgsrc/devel/py-meson_python.

(no LANG, LC_* set):

# tar xvzf meson_python-0.20.0.tar.gz
tar: Pathname can't be converted from UTF-8 to current locale
tar: Error exit delayed from previous errors

The relevant file name is

meson_python-0.20.0/tests/packages/encoding/\343\203\206\343\202\271\343\203\210.py

or

meson_python-0.20.0/tests/packages/encoding/テスト.py

in a UTF-8 locale.

Is this an intended consequence of the change?
 Thomas