Re: GLES

matthew green <[email protected]> wrote:
>Robert Swindells writes:
>> 
>> I have put my diffs and new files to add GLESv[23] to the build at:
>>
>> <https://ftp.netbsd.org/pub/NetBSD/misc/rjs/gles.tar.gz>
>>
>> The GLES3 headers are handled by a target under external/mit/xorg/include
>> and the GLES2 headers and libraries by one under external/mit/xorg/lib.
>>
>> With a matching diff to pkgsrc pkgtools/x11-links, the x11/zutty package
>> builds and seems to work.
>
> looks pretty good.  thanks for working on this.
>
> the sets probably need help for old xorg-server platforms, or at
 >least confirm it builds ok there (build.sh -m vax -x.)

Have added mesa_ver=21 to all the entries.

> what's the "old" and "new" comments for CPPFLAGS in the Makefile?

The Makefile was originally copied from external/mit/xorg/lib/libGL,
it has this split.

I pruned back the list of referenced libraries but didn't go through
and check every CPPFLAGS entry.

>            s,@GL_PC_LIB_PRIV@,-lm -lpthread -pthread,; \
>
> has a double pthread, and otherwise *does* match the version in
> bsd.x11.mk now.  that line, and two around it:
>
>        -e "s,@GL_PKGCONF_LIB@,GLESv2,; \
>            s,@GL_PC_CFLAGS@,,"
>
> but i don't see *any* of these used any more?  i only seem to
> seem similar ones for GLUT and GLW now days.
>
> you shouldn't really need to set -pthread in CFLAGS *and* also
> set LDADD/DPADD.  -pthread tells the compiler to do the right
> things.  (it _will_ have a positive effect for static only hosts
> that will re-link if changed.  dynamic, doesn't really need the
> relink except to run the linker checkers.)  (maybe we do this
> elsewhere and you merely copied the method.)
>
> oh, the .pc.in also has the doubled -lpthread thing.

As part of doing the MesaLib update I created a dummy pkgsrc package
for the same Mesa version, the new generated files were copied from a
build of this package.

I just copied what upstream was doing with the pthread flag and
library, keeping base and modular x11 versions in sync seemed a good
idea.

If it isn't needed then maybe we should change it in base and pkgsrc
at the same time, then push a patch upstream.