Re: Using MMC on HoneyComb LX2 (patch)
Jason Thorpe <[email protected]>
| Newsgroups | gmane.os.netbsd.ports.arm |
|---|---|
| Message-ID | <[email protected]> |
> On Mar 26, 2024, at 8:24 PM, Mouse <[email protected]> wrote: > Should be superfluous, maybe. I've repeatedly been surprised at how > often firewall checks like those trip. > > Whether to convert them to a panic, possibly only if DIAGNOSTIC or > DEBUG or sokme such, or just fail to attach (possibly with a message), > I could argue that either way. But I would argue they should be kept > in some form. Then make a KASSERT() that it’s not NULL so that the unnecessary cost isn’t paid on release builds. -- thorpej