ODROID C2 + I2C: request for code review and help

Vincent DEFERT <[email protected]>
Newsgroups gmane.os.netbsd.ports.arm
Message-ID <[email protected]>
Hi,

I'm working on an I2C driver for the amlogic meson architecture, testing 
it on ODROID C2.
The configuration is correct, the driver attaches to the FDT and 
responds to the iic_exec ioctl.
However, the interrupt handler is never calledand I have no clue why.

It is the first time I write a NetBSD driver, so I'd appreciate a code 
review.
I also welcome any advice as to what I can try to make it work. :)

The code can be downloaded at https://www.defert.com/meson-i2c.tgz
It is intended to be untarred in /usr/src/sys, or wherever else you have 
your kernel sources.
It also has a TEST-PGM directory with a test program that writes and 
reads a 24C256 I2C EEPROM.

My kernel configuration is called ODROID-C2.
I had to modify meson-gxbb-odroidc2.dts, so it also needs to be recompiled.
I have included comments in the files I modified so you can easily 
locate my changes (search BEGIN_MESONI2C_MOD).

Thank you in advance!

Vincent
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.