Re: Rockchip RK3588

On 15/09/2025 17:21, Robert Swindells wrote:
> I have got the PCIe PHY and host controller drivers from OpenBSD to compile.
> 
> The host controller isn't doing anything when it the driver attach
> function enables link training.
> 
> My next thing to check is whether all the power stuff for it is enabled
> so have started looking at your tree.
Nice to hear that there's progress in that area!

> The way that you have done the RK806 driver by putting an SPI attachment
> in an I2C source file looks messy to me, it doesn't share anything with
> the i2c code.

Fair enough.  Initially I thought there could be some code shared 
between RK805 and RK806 (the later one could be attached either via I2C 
or SPI).  But in any case the right approach would be to extract the 
common stuff and keep only the transport-related pieces in i2c/ or spi/ 
directories.

> I have split it out into its own file under dev/spi in my tree and made
> some changes to match the recent spi updates.
> 
> Copied across your rkpmu driver, how complete do you think this is?

Unfortunately, the rkpmic is probably the hackiest part in my whole 
patch stack (ignoring rkvop2) :(
The only thing rk806 driver can do right now is power off the device. 
It has lots of debugging prints and commented-out code left.

I will start by cleaning up the patch implementing half-duplex transfer 
for rkspi in a 3-wire setup, which was the main effort needed to start 
talking to the rk806.  Then it could use some testing on different 
devices to make sure it doesn't break the 4-wire use case.

Is your tree available somewhere public so I could have a look at the 
current status?

Best regards
Johann