module(7) vs KERN_AS (Re: HEADS-UP: Recent atari install floppy overflow)

This is a multi-part message in MIME format.
--------------1A975F2C71762C0618DF3366
Content-Type: text/plain; charset=us-ascii; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit

Hi,

Currently, KERN_AS is set in Makefile.arch. However, it should be
determined on whether module(7) is enabled or not, for *all* ports,
something like

   OPT_MODULAR=	%MODULAR%
   .if !empty(OPT_MODULAR)
   KERN_AS=	obj
   .else
   KERN_AS=	library
   .endif

Therefore, it is not a good idea to have the common segment of
codes above in all Makefile.arch. We would have three options:

(1) use sys/conf/Makefile.conf

(2) add %MODULAR directive and emitmodular() function in config(1)

(3) set OPT_MODULAR in Makefile.arch, and change a default value for
KERN_AS depending on its value in sys/lib/libkern/Makefile.inc

(1) does not work since %MODULAR% is not expanded if it is in
sys/conf/Makefile.conf. And (2) seems too much for me. Therefore,
I propose (3) as a compromise. Please find the attached patch (MD
part is only for amd64 as an example).

Thoughts?

Thanks,
rin

On 2018/09/18 21:52, [email protected] wrote:
> I'd like to propose the following to remove dead code intended for
> modules, which are not enabled.
>

--------------1A975F2C71762C0618DF3366
Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0";
 name="libkern_module_20180919.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="libkern_module_20180919.patch"

SW5kZXg6IHN5cy9jb25mL01ha2VmaWxlLmtlcm4uaW5jCj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZp
bGU6IC9ob21lL25ldGJzZC9zcmMvc3lzL2NvbmYvTWFrZWZpbGUua2Vybi5pbmMsdgpyZXRy
aWV2aW5nIHJldmlzaW9uIDEuMjY1CmRpZmYgLXAgLXUgLXIxLjI2NSBNYWtlZmlsZS5rZXJu
LmluYwotLS0gc3lzL2NvbmYvTWFrZWZpbGUua2Vybi5pbmMJMjcgQXVnIDIwMTggMDU6MzU6
MjIgLTAwMDAJMS4yNjUKKysrIHN5cy9jb25mL01ha2VmaWxlLmtlcm4uaW5jCTE5IFNlcCAy
MDE4IDA2OjM0OjA0IC0wMDAwCkBAIC0xNTcsOCArMTU3LDggQEAgTElOS19PPz0JQCR7X01L
U0hNU0d9ICIgICBsaW5rICAkey5DVVJESQogIyMKICMjICgzKSBsaWJrZXJuIGFuZCBjb21w
YXQKICMjCi0jIyBTZXQgS0VSTl9BUyBpbiB0aGUgcG9ydCBNYWtlZmlsZSB0byAib2JqIiBv
ciAibGlicmFyeSIuICBUaGUKLSMjIGRlZmF1bHQgaXMgImxpYnJhcnkiLCBhcyBkb2N1bWVu
dGVkIGluICRTL2xpYi9saWJrZXJuL01ha2VmaWxlLmluYy4KKyMjIFNldCBPUFRfTU9EVUxB
UiBpbiB0aGUgcG9ydCBNYWtlZmlsZSBpZiBtb2R1bGUoNykgc2hvdWxkIGJlIGVuYWJsZWQs
CisjIyBhcyBkb2N1bWVudGVkIGluICRTL2xpYi9saWJrZXJuL01ha2VmaWxlLmluYy4KICMj
CiAKICMjIyBmaW5kIG91dCB3aGF0IHRvIHVzZSBmb3IgbGlia2VybgpJbmRleDogc3lzL2xp
Yi9saWJrZXJuL01ha2VmaWxlLmluYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvaG9tZS9u
ZXRic2Qvc3JjL3N5cy9saWIvbGlia2Vybi9NYWtlZmlsZS5pbmMsdgpyZXRyaWV2aW5nIHJl
dmlzaW9uIDEuNDUKZGlmZiAtcCAtdSAtcjEuNDUgTWFrZWZpbGUuaW5jCi0tLSBzeXMvbGli
L2xpYmtlcm4vTWFrZWZpbGUuaW5jCTI3IE1heSAyMDE4IDAxOjE0OjUwIC0wMDAwCTEuNDUK
KysrIHN5cy9saWIvbGlia2Vybi9NYWtlZmlsZS5pbmMJMTkgU2VwIDIwMTggMDY6MzE6Mzgg
LTAwMDAKQEAgLTcsNyArNyw4IEBACiAjCQlvYmplY3RzIGFyZSB0byBiZSBidWlsdC4gIERl
ZmF1bHRzIHRvICR7Lk9CSkRJUn0vbGliL2tlcm4uCiAjCUtFUk5fQVMJbWF5IGJlIHNldCB0
byAnb2JqJyB0byBidWlsZCBhIG9iamVjdCBmcm9tIHRoZSBsaWJyYXJ5J3MKICMJCW9iamVj
dCBmaWxlcy4gIChPdGhlcndpc2UsIGEgbGlicmFyeSB3aWxsIGJlIGJ1aWx0LikKLSMJCURl
ZmF1bHRzIHRvICdsaWJyYXJ5Jy4KKyMJCURlZmF1bHRzIHRvICdvYmonIGlmIE9QVF9NT0RV
TEFSIGlzIHNldC4gT3RoZXJ3aXNlLAorIwkJJ2xpYnJhcnknIGlzIHVzZWQgYXMgYSBkZWZh
dWx0IHZhbHVlLgogIwlLRVJOTUlTQ0NQUEZMQUdTCiAjCQlNaXNjZWxsYW5lb3VzIGNwcCBm
bGFncyB0byBiZSBwYXNzZWQgdG8gdGhlIGxpYnJhcnkncyBNYWtlZmlsZQogIwkJd2hlbiBi
dWlsZGluZy4KQEAgLTE4LDcgKzE5LDEzIEBACiAKICMgRGVmYXVsdCB2YWx1ZXM6CiBLRVJO
RFNUPz0JJHsuT0JKRElSfS9saWIva2VybgotS0VSTl9BUz89CWxpYnJhcnkKKy5pZiAhZGVm
aW5lZChLRVJOX0FTKQorLmlmICFlbXB0eShPUFRfTU9EVUxBUikKK0tFUk5fQVM9CW9iagor
LmVsc2UKK0tFUk5fQVM9CWxpYnJhcnkKKy5lbmRpZgorLmVuZGlmCiBLRVJORE9URElSPz0g
Li4vLi4vLgogCiBLRVJORElSPQkke1M6U0BeLkAke0tFUk5ET1RESVJ9QDpxfS9saWIvbGli
a2VybgpJbmRleDogc3lzL2FyY2gvYW1kNjQvY29uZi9NYWtlZmlsZS5hbWQ2NAo9PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09ClJDUyBmaWxlOiAvaG9tZS9uZXRic2Qvc3JjL3N5cy9hcmNoL2FtZDY0L2NvbmYv
TWFrZWZpbGUuYW1kNjQsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNzMKZGlmZiAtcCAtdSAt
cjEuNzMgTWFrZWZpbGUuYW1kNjQKLS0tIHN5cy9hcmNoL2FtZDY0L2NvbmYvTWFrZWZpbGUu
YW1kNjQJMjIgQXVnIDIwMTggMTI6MDc6NDIgLTAwMDAJMS43MworKysgc3lzL2FyY2gvYW1k
NjQvY29uZi9NYWtlZmlsZS5hbWQ2NAkxOSBTZXAgMjAxOCAwNjoyMjoyMCAtMDAwMApAQCAt
NjMsMTEgKzYzLDYgQEAgQ0ZMQUdTKz0JJHtLQVNBTkZMQUdTLiR7LklNUFNSQzpUfTpVJHtL
QQogIyMgKDMpIGxpYmtlcm4gYW5kIGNvbXBhdAogIyMKIE9QVF9NT0RVTEFSPQklTU9EVUxB
UiUKLS5pZiAhZW1wdHkoT1BUX01PRFVMQVIpCi1LRVJOX0FTPQlvYmoKLS5lbHNlCi1LRVJO
X0FTPQlsaWJyYXJ5Ci0uZW5kaWYKIAogIyMKICMjICg0KSBsb2NhbCBvYmplY3RzLCBjb21w
aWxlIHJ1bGVzLCBhbmQgZGVwZW5kZW5jaWVzCg==
--------------1A975F2C71762C0618DF3366--