Re: RFC: cleaning up j720ssp.c

Ignatios Souvatzis <[email protected]> Tue, 17 Jan 2006 15:38:06 +0100

Newsgroups	gmane.os.netbsd.ports.hpcarm
Message-ID	<[email protected]>

On Tue, Jan 17, 2006 at 03:30:21PM +0100, Peter Postma wrote:

> The last file might possibly be moved to arm/sa11x0/sa11x0_ssp.c (plus some
> general functions to access it?) because the SSP seems to be part of
> the SA-1110 according to the Intel docs.

My favourite nit: You should put the SA1100 stuff into files named
sa1100*, not sa11x0* - there's a lot of stuff in there that's different
(unless the specific stuff is compatible, of course).

Same for  sa101 / sa1x1 / sa111.

[Does it show that I looked at the j820 again?]

Regards,
	-is
-- 
seal your e-mail: http://www.gnupg.org/

signature.asc (application/pgp-signature, 186 B)

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (NetBSD)

iD8DBQFDzQFON4tiz3B8hB0RAjsiAJ47Df5bqfVkUSJvAdVFOdhmD1HStwCgwpKJ
owlA/M2VLCbY/8bOcG6W5Q8=
=9tKq
-----END PGP SIGNATURE-----