Re: RFC: cleaning up j720ssp.c

On Wed, Feb 22, 2006 at 02:17:21PM +0100, Peter Postma wrote:
> On Tue, Feb 21, 2006 at 05:09:45PM +0100, Quentin Garnier wrote:
> > On Tue, Feb 21, 2006 at 04:22:41PM +0100, Peter Postma wrote:
> > > static int
> > > hpcapm_match(struct device *parent, struct cfdata *cf, void *aux)
> > > {
> > > 	struct mainbus_attach_args *ma = aux;
> > > 
> > > 	if (strcmp(ma->ma_name, hpcapm_cd.cd_name) != 0) {
> > > [..]
> > > 
> > > Or do you suggest to work around this?
> > 
> > This is completely broken.  There are quite some config(9) abuses in hpc
> > land...  I'll have a look at hpcapm users and fix that mess.  Th
> > hpcapm/apmdev separation looks dubious, too.
> > 
> 
> Do you have any idea how long this will take (I'd like to get this all done
> before 4.0 will be branched).

I have the conversion ready.  I'm waiting for the hpcmips part to be
tested, and then I'll commit.

> I've put a hpcapm(4)'ified j720pwr.c here (untested):
> ftp://ftp.netbsd.org/pub/NetBSD/misc/peter/j720pwr.c

I'll try to work out a patch for you to test tomorrow.
 
> Yes, this needs "j720pwr* at j720ssp?" to install the config hooks, but
> I'm afraid there's no better solution.

Well, as you said in an early mail, ssp might get slightly less MD, so
it's acceptable.

> > One thing I don't quite get in your patch though is the extra layer for
> > each objects.  hpckbd should attach directly to j720ssp;  the split in
> > different source files is fine, though.
> 
> Is this a showstopper, i.e. does this need to be fixed before committing?

No, and as I say earlier, if moving ssp code out in a more generic form
is indeed the plan, then it's fine that way.

-- 
Quentin Garnier - [email protected] - [email protected]
"When I find the controls, I'll go where I like, I'll know where I want
to be, but maybe for now I'll stay right here on a silent sea."
KT Tunstall, Silent Sea, Eye to the Telescope, 2004.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (NetBSD)

iQEVAwUBQ/0GsNgoQloHrPnoAQIqZAf/UuCukTMMBSRgdImoClIUyWny9L+YO9yA
UK1ZZSXs9ryqX/jGJjHhfsn9ZzALkKx4vLnny8GXBplQ7nW7uZ680qmfvg6X6Eh6
tTnZvZhknUlQGEXRZ8ORkcPQjRnE0jnRT8o+Bq76e42OyAA8wuKn5YHCgmeHh5qJ
ovKi2EdSqMrRsCv4Jwi4+1QN07iITJAuNUS87aOYd1K5jatA1lvvUttVInbZNiqt
s0ApAYatKFczEZ7EVdbdPHFqzJvbE+YqhvjWYgQwmpPMO8/1jDIdrrANP4x6JT2I
NyYIWWgSwGFUg4G3M7fNZct06GN7Qka8QR4cUCCetXyO2aK+qGs0nQ==
=RbrJ
-----END PGP SIGNATURE-----