Re: RFC: cleaning up j720ssp.c

On Sun, Feb 26, 2006 at 11:28:21PM +0100, Peter Postma wrote:
> On Thu, Feb 23, 2006 at 01:49:52AM +0100, Quentin Garnier wrote:
> > I have the conversion ready.  I'm waiting for the hpcmips part to be
> > tested, and then I'll commit.
> > 
> 
> I saw that you've committed the changes... thanks.
> 
> I've updated the j720pwr.c and tested it and it seems to work fine now.
> Patches are updated and available at the same place.
> 
> I had to make a small change to hpcapm.c, removing the include
> machine/autoconf.h. I don't think that will affect the other hpc ports
> but I'll cross-compile them to be sure.

I think it's a left over;  it probably was needed for struct
mainbus_attach_args, which of course is not used anymore.

> And there's a minor compatibility problem... the apmdev device uses
> a different major number from the apm device, so users will need to
> create a new device node. I've created a new major file

Hum, no.  Just use the same major as before.

> (hpcarm/conf/majors.hpcarm) for this (arm/conf/majors.arm32 didn't feel
> right). A new apm binary is also required to query the status.

I'd rather have a MI definition for hpcapm.  But we'll still need a
definition for compat_30 anyway.

Why would a new binary be required?  AFAICT, the ABI doesn't change.

> So maybe this should be noted in src/UPDATING and/or -current-users.

I don't think we have a compatibility problem.  I'll have to think more
about it though.

-- 
Quentin Garnier - [email protected] - [email protected]
"When I find the controls, I'll go where I like, I'll know where I want
to be, but maybe for now I'll stay right here on a silent sea."
KT Tunstall, Silent Sea, Eye to the Telescope, 2004.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (NetBSD)

iQEVAwUBRAI8H9goQloHrPnoAQLSmwf+MOvFBcdpDn/ZTYfT2tOX14xfGqe+wiL7
SqjrtEXYMokP54LH/jDFCpQbCaeWrioVLJEgINIecYWcoy1Q7N45rsqx1WBRy339
yfjhasT11aYxVGkkg9zI3NjjWiWZzFBOSUMxQj4j/C7okcckIjicwKekn8rChx4K
AhG2bSa8ZpviA/jCLW73uLgJ8hGckWFKmediYj7IOnG2WmWs+R1a/89OtDuJvus/
HK9C+EMURxom7cgQR/yKreqw2vQW3F7ty3oJfZhCCIipGIlG4HK8ZAkkd2zNAcid
XrCXNjvn71KpjKZtKDSe0N41regmHkCUcpbRfCjX/Z5ObZYzIxh18w==
=8tOG
-----END PGP SIGNATURE-----