Re: Patch: Generic TODR for ARM ports

Peter Postma wrote:
> On Sun, Sep 17, 2006 at 09:15:55AM -0700, Garrett D'Amore wrote:
>   
>> Peter Postma wrote:
>>     
>>> timecounter: Timecounters tick every 10.000 msec
>>> timecounter: Timecounter "clockinterrupt" frequency 100 Hz quality 0
>>> timecounter: selected timecounter "clockinterrupt" frequency 100 Hz quality 0
>>> timecounter: Timecounter "saost_count" frequency 3686400 Hz quality 100
>>> timecounter: selected timecounter "saost_count" frequency 3686400 Hz quality 100
>>> timecounter: selected timecounter "saost_count" frequency 3686400 Hz quality 100
>>>   
>>>       
>> The double selection messages suggest that you need to update the kernel
>> from CVS.  A change was made to todr to prevent tc_windup() from getting
>> called with interrupts enabled -- I think that is what has happened
>> here.  (You should not see double messages like this.)
>>     
>
> I believe that I'm up to date :-) which revisions should I have?
>
>   
>>> I can put the diffs online for review, but they are really trivial.
>>>   
>>>       
>> That would be great.  If they are generic, it would be a good idea to
>> wrap them in #ifdef __HAVE_TIMECOUNTER so that evbarm can pick them up too.
>>
>>     
>
> Yes, saost is also used by at least 3 evbarm ports. Diff is here:
> ftp://ftp.netbsd.org/pub/NetBSD/misc/peter/saost-tc.diff
>
>   

This looks great to me.  I'd say post it, but I'm still waiting on
approval to commit the GENERIC-TODR changes.  Wait a little bit, and
I'll tell you when it is safe to commit...

-- 
Garrett D'Amore, Principal Software Engineer
Tadpole Computer / Computing Technologies Division,
General Dynamics C4 Systems
http://www.tadpolecomputer.com/
Phone: 951 325-2134  Fax: 951 325-2191