Re: once more psh3pwr(4)

Hi! uwe,


From: "Valeriy E. Ushakov" <[email protected]>
Date: Sun, 23 Sep 2007 22:08:56 +0400

> On Mon, Sep 24, 2007 at 01:42:53 +0900, KIYOHARA Takashi wrote:

> > 	/* regsiter sleep function to APM */
> > 	__sleep_func = psh3pwr_sleep;
> > 	__sleep_ctx = self;
> 
> Also arrange necessary config_hooks to get hpcapm connected to this
> driver?

hmm.. I can't know your meaning.  X-<


> > 	sc->sc_data.sensor = 0;
> > 	sc->sc_data.units = ENVSYS_INDICATOR;
> > 	sc->sc_data.state = ENVSYS_SVALID;
> > 	sc->sc_data.value_cur = sc->sc_plug;
> > 	snprintf(sc->sc_data.desc, sizeof(sc->sc_data.desc),
> > 	    "%s %s", sc->sc_dev.dv_xname, "plug");
> 
> I wonder if it makes sense to convert hpcapm to use sysmon instead of
> doing that in each driver (just thinking out loud here).

In a word, should we treat sysmon_envsys with hpcapm layer?


> > 	/* splhigh on entry */
> > 	extern void pfckbd_poll_hitachi_power(void);
> 
> I assume this will be in pfckbd.c.  Isn't there any interrupt to wake
> us up?

Oops.
Yes.  Our PERSONA not occur the interrupt to power-button with on/off.
Therefore, we are setting *_ special_keymap in hpckbdkeymap.h.  And,
KEY_SPECIAL_OFF is detected with hpckbd.c.

Thanks,
--
kiyohara