Re: [PATCH] Add intr_mask() / intr_unmask() interface to mask / unmask individual interrupt sources
Manuel Bouyer <[email protected]>
| Newsgroups | gmane.os.netbsd.ports.x86-64,gmane.os.netbsd.ports.i386 |
|---|---|
| Message-ID | <[email protected]> |
On Sat, Nov 30, 2019 at 09:53:23AM -0800, Jason Thorpe wrote: > > > > On Nov 30, 2019, at 9:48 AM, Manuel Bouyer <[email protected]> wrote: > > > > Just please make sure that the i2c code (espeically hid over i2c) can > > still run without the mask/unmask MD parts (this will probably require some > > #ifdef unfortunably). > > That's not possible -- the whole point is to get rid of i2c access in interrupt context (because it's not safe, even with I2C_F_POLL). This depends on the backend controller. iichid on x86 is working fine as is on my laptop ... I still believe we'll need some #define to know if the MD interrupt code provides working mask/unmask until all ports provide them. This will be usefull for more hardware than i2c ... -- Manuel Bouyer <[email protected]> NetBSD: 26 ans d'experience feront toujours la difference --