Re: [PATCH] Add intr_mask() / intr_unmask() interface to mask / unmask individual interrupt sources
Jason Thorpe <[email protected]>
| Newsgroups | gmane.os.netbsd.ports.x86-64,gmane.os.netbsd.ports.i386 |
|---|---|
| Message-ID | <[email protected]> |
> On Nov 30, 2019, at 3:07 PM, Jason Thorpe <[email protected]> wrote: > > So I think these are already safely serialized, although I could add an extra measure of safety by disabling interrupts on the current CPU around those 3 lines of code to make absolutely sure that cross-call doesn't arrive until we're done. Yah, on second thought, I don't think I will add that additional code... as far as I can tell, it's completely unnecessary (because it's all already serialized with cpu_lock) and would only add confusion. I will add a comment about the mask count being protected with cpu_lock, however. -- thorpej