Re: [PATCH] x86/intr.c: fix build if NO_PCI_MSI_MSIX is defined

--000000000000b283e60616dc219d
Content-Type: text/plain; charset="UTF-8"

Hi,

The patch was already applied, thanks.

On Wed, Apr 24, 2024, 18:47 Paolo Pisati <[email protected]> wrote:

> ...
> /home/flag/bsd/netbsd/src/sys/arch/x86/x86/intr.c: In function
> 'intr_create_intrid':
> /home/flag/bsd/netbsd/src/sys/arch/x86/x86/intr.c:315:34: error:
> 'MSI_INT_DEV_MASK' undeclared (first use in this function)
>   315 |   pih = __SHIFTIN((uint64_t)dev, MSI_INT_DEV_MASK)
>       |                                  ^~~~~~~~~~~~~~~~
> ...
>
> Signed-off-by: Paolo Pisati <[email protected]>
> ---
>  sys/arch/x86/x86/intr.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/sys/arch/x86/x86/intr.c b/sys/arch/x86/x86/intr.c
> index a94ea7f17707..beb3dab5673b 100644
> --- a/sys/arch/x86/x86/intr.c
> +++ b/sys/arch/x86/x86/intr.c
> @@ -138,6 +138,7 @@ __KERNEL_RCSID(0, "$NetBSD: intr.c,v 1.167 2024/03/05
> 20:58:05 andvar Exp $");
>  #include "opt_intrdebug.h"
>  #include "opt_multiprocessor.h"
>  #include "opt_acpi.h"
> +#include "opt_pci.h"
>
>  #include <sys/param.h>
>  #include <sys/systm.h>
> --
> 2.34.1
>
>

--000000000000b283e60616dc219d
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto">Hi,<div dir=3D"auto"><br></div><div dir=3D"auto">The patc=
h was already applied, thanks.</div></div><br><div class=3D"gmail_quote"><d=
iv dir=3D"ltr" class=3D"gmail_attr">On Wed, Apr 24, 2024, 18:47 Paolo Pisat=
i &lt;<a href=3D"mailto:[email protected]">[email protected]</a>&gt; wrot=
e:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;bo=
rder-left:1px #ccc solid;padding-left:1ex">...<br>
/home/flag/bsd/netbsd/src/sys/arch/x86/x86/intr.c: In function &#39;intr_cr=
eate_intrid&#39;:<br>
/home/flag/bsd/netbsd/src/sys/arch/x86/x86/intr.c:315:34: error: &#39;MSI_I=
NT_DEV_MASK&#39; undeclared (first use in this function)<br>
=C2=A0 315 |=C2=A0 =C2=A0pih =3D __SHIFTIN((uint64_t)dev, MSI_INT_DEV_MASK)=
<br>
=C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^~~~~~~~=
~~~~~~~~<br>
...<br>
<br>
Signed-off-by: Paolo Pisati &lt;<a href=3D"mailto:[email protected]" targe=
t=3D"_blank" rel=3D"noreferrer">[email protected]</a>&gt;<br>
---<br>
=C2=A0sys/arch/x86/x86/intr.c | 1 +<br>
=C2=A01 file changed, 1 insertion(+)<br>
<br>
diff --git a/sys/arch/x86/x86/intr.c b/sys/arch/x86/x86/intr.c<br>
index a94ea7f17707..beb3dab5673b 100644<br>
--- a/sys/arch/x86/x86/intr.c<br>
+++ b/sys/arch/x86/x86/intr.c<br>
@@ -138,6 +138,7 @@ __KERNEL_RCSID(0, &quot;$NetBSD: intr.c,v 1.167 2024/03=
/05 20:58:05 andvar Exp $&quot;);<br>
=C2=A0#include &quot;opt_intrdebug.h&quot;<br>
=C2=A0#include &quot;opt_multiprocessor.h&quot;<br>
=C2=A0#include &quot;opt_acpi.h&quot;<br>
+#include &quot;opt_pci.h&quot;<br>
<br>
=C2=A0#include &lt;sys/param.h&gt;<br>
=C2=A0#include &lt;sys/systm.h&gt;<br>
-- <br>
2.34.1<br>
<br>
</blockquote></div>

--000000000000b283e60616dc219d--