Re: Does anyone use xterm on NetBSD/m68k 7.0?

On 2015/11/09 18:40, Michael van Elst wrote:
> The broken code can be found in xsrc/external/mit/libX11/src/UIThrStubs.c.
> As we already provide no-thread compatibility functions in libc (with
> a working pthread_getspecific implementation) it might also help to
> get rid of this UIThrStubs nonsense.

Awesome! You solved the problem! In summary,

(1) libc and gcc are nothing to do with the problem
(2) the cause of the problem is that libX11 poisons namespace of libc,
     replacing non-threaded stubs by broken ones with incorrect prototypes
(3) Xorg-based xterm *accidentally* works on ports other than m68k,
     or with libc built with -O1 flag on m68k

Is my understanding correct?

As you pointed out, we have non-threaded stubs in src/lib/libc/thread-stub.
I think we don't need UIThrStubs.c. Actually, X server and xterm work fine
with libX11 built without it on x68k:

====
--- src/external/mit/xorg/lib/libX11/Makefile.libx11.orig	2015-11-09 19:43:39.000000000 +0900
+++ src/external/mit/xorg/lib/libX11/Makefile.libx11	2015-11-09 19:47:04.000000000 +0900
@@ -265,8 +265,8 @@
  	XlibInt.c \
  	Xrm.c
  
-SRCS+=	\
-	UIThrStubs.c
+#SRCS+=	\
+#	UIThrStubs.c
  
  SRCS+=	\
  	AddDIC.c \
====

I will check whether it works or not on other port, earmv7eb, in few hours.

Now, the title and category of my PR turned out to be wrong. Should I better
to require it withdrawn, and send a new one?