Re: playstation2 changes

Andrius V <[email protected]> Wed, 8 Nov 2023 12:37:58 +0200
Newsgroups gmane.os.netbsd.ports.mips.devel
Message-ID <CAFO4Nkr0fE_xTtyBfjHuSFkPSGa0VJramkBo17GSG3S+SmiDUA@mail.gmail.com>
I have a bit more changes to potentially improve the build:
https://netbsd.org/~andvar/playstation2_2.diff, however it currently
feels more like patching the corpse :). There are still a several of
issues to resolve, before playstation2 kernel can be build (didn't try
userland)
Additionally, some specific R5900 code was deleted during "grand
refactoring", which may be partially due to the fact that playstation2
was removed from base at that point.

Regarding this change, I can see that other mips ports include
<mips/intr.h> above #ifdef _KERNEL.




On Wed, Nov 8, 2023 at 12:21 AM John D. Baker <[email protected]> wrote:
>
> Since playstation2 has been getting some love recently, here's something
> I found while keeping up with building userland.
>
> The following patch seems to be the appropriate way to handle things:
>
> >Index: sys/arch/playstation2/include/intr.h
> >===================================================================
> >RCS file: /cvsroot/src/sys/arch/playstation2/include/intr.h,v
> >retrieving revision 1.12
> >diff -u -p -r1.12 intr.h
> >--- sys/arch/playstation2/include/intr.h       31 Mar 2014 11:41:01 -0000      1.12
> >+++ sys/arch/playstation2/include/intr.h       11 Aug 2023 01:24:41 -0000
> >@@ -31,7 +31,7 @@
> >
> > #ifndef _PLAYSTATION2_INTR_H_
> > #define _PLAYSTATION2_INTR_H_
> >-#ifdef _KERNEL
> >+#if defined (_KERNEL) || defined (_KMEMUSER)
> >
> > #include <mips/intr.h>
> >
>
> --
> |/"\ John D. Baker, KN5UKS               NetBSD     Darwin/MacOS X
> |\ / jdbaker[snail]consolidated[flyspeck]net  OpenBSD            FreeBSD
> | X  No HTML/proprietary data in email.   BSD just sits there and works!
> |/ \ GPGkeyID:  D703 4A7E 479F 63F8 D3F4  BD99 9572 8F23 E4AD 1645