bug, MIPS mach-rc32434/pci.h

DiTBho Down in The Bunny hole <[email protected]> Wed, 18 Dec 2024 17:08:40 +0100

Newsgroups	gmane.os.netbsd.ports.mips.devel
Message-ID	<CAAZ8i81T2Ze+8Uzz5jf_kuCU4Une1FaAaw5p4c7nFLGsSmq9Sg@mail.gmail.com>

hi
found a typo in a #define, see the char "_" is missing.
It silently causes catastrophic consequences to miniPCI devices such
as uart, crypto accelerators, wifi, ...

I found this bug from kernel 4.4 to kernel 6.12.
I think it should be fixed

D.

--- arch/mips/include/asm/h.original   2024-12-17 19:18:40.199000000 -0000
+++ arch/mips/include/asm/mach-rc32434/pci.h    2024-12-17
19:18:40.189000000 -0000
@@ -167,7 +167,7 @@
 #define PCI_CFGA_DEV           0x0000f800
 #define PCI_CFGA_DEV_INTERN    0
 #define PCI_CFGA_BUS_BIT       16
-#define PCI CFGA_BUS           0x00ff0000
+#define PCI_CFGA_BUS           0x00ff0000
 #define PCI_CFGA_BUS_TYPE0     0
 #define PCI_CFGA_EN            (1 << 31)