Re: New wsdisplay for playstation2

Matthias Drochner <[email protected]> Tue, 28 Oct 2003 19:06:55 +0100

Newsgroups	gmane.os.netbsd.ports.playstation2,gmane.os.netbsd.devel.kernel
Message-ID	<[email protected]>

[email protected] said:
> gsfb_mmap(void *v, off_t offset, int prot) {
> 	if (GSFB_BUFFER_SIZE >= (unsigned) offset)
> 	    return NULL; 

I didn't look deeper, but this piece of code is wrong for two
reasons:
1. the comparision is reverted
2. returning NULL doesn't what you expect - probably you get
   the physical page at 0 mapped
   to return an error, use (-1)

best regards
Matthias