Re: Regression of GCC >= 4.8.5 for 32-bit powerpc

Matt Thomas <[email protected]> Tue, 13 Dec 2016 20:11:09 -0800
Newsgroups gmane.os.netbsd.ports.powerpc,gmane.os.netbsd.devel.toolchain
Message-ID <[email protected]>
> On Dec 13, 2016, at 8:06 PM, Rin Okuyama <[email protected]> wrote:
> 
> Thank you for your correction. I slightly modified your version
> in order to avoid dangling ".machine". With this patch, I obtained
> working kernel and userland for IBM 405 (evbppc). Also, build.sh
> successfully completes for evbppc-powerpc64. Is this OK with you?
> 
> Rin

Look fine.

> +	p = "ppc64";
> +      else if (!global_options_set.x_rs6000_cpu_index)
> +	p = "ppc";
> +      if (p != NULL)
> +	fprintf (asm_out_file, "\t.machine %s\n", p);
>     }
> #endif

However.  You can drop the "if (p != NULL)" if you do

	else
	  return;
	gcc_assert(p != NULL);
	fprintf (asm_out_file, "\t.machine %s\n", p);

Pendantic I know.