Re: pmap_extract vs. P1 and P2 addresses (port-sh3/26569)

On Wednesday 08 February 2006 21:23, Valeriy E. Ushakov wrote:
> Attached patch fixes port-sh3/26569.  The problem is that sh3 defines
>
>     #define	PMAP_MAP_POOLPAGE(pa) SH3_PHYS_TO_P1SEG((pa))
>
> and when pmap_extract is called on that P1 address we lose.
>
> Can anyone think of why the attached fix might be a bad idea?  Do we
> need something more elaborate (b/c I miss something about sh3 pmap),
> or is the wildcard P1/P2 test there is ok?

Looks good to me. Several other pmaps which allocate pool pages from the 
same PA:VA segments use this approach.

Cheers, Steve