Re: README: ports switching to GCC 8.
Michael van Elst <[email protected]>
| Newsgroups | gmane.os.netbsd.ports.sparc64 |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Dec 03, 2019 at 11:21:42AM -0800, Jason Thorpe wrote: > > > On Dec 3, 2019, at 10:39 AM, Michael L. Hitch <[email protected]> wrote: > > > > OK, I was able to track down the commit that causes this failure, and it > > was not obvious. The commit was revision 1.69 of sys/dev/i2c/i2c.c. This > > resulted in attempting to configure amdtemp0 instead of gpio0. Reverting > > this change results in a working kernel - both netbsd-9 (gcc7) and > > -current (gcc8). > > I'm not sure what the motivation for that change was: The intention was obviously to allow indirect matches again. > ---------------------------- > revision 1.69 > date: 2019-03-26 09:20:38 +0000; author: mlelstv; state: Exp; lines: +8 -4; commitid: NzJPOJHDHtCW7RgB; > touch match_result only on success. > ---------------------------- > > It's clearly not correct. The "true" or "false" return means "you should use the match_result that's returned". That didn't change. -- Michael van Elst Internet: [email protected] "A potential Snark may lurk in every tree."