Re: Firefox52 broken on NetBSD9.3 / pkgsrc-2022Q4

On Sat, Jan 28, 2023 at 1:22 PM Martin Husemann <[email protected]> wrote:
>
> On Wed, Jan 25, 2023 at 08:30:10PM +0100, Connor McLaughlan wrote:
> > Thread 1 "" received signal SIGSEGV, Segmentation fault.
> > 0x000000004cb09ec4 in CallQueryInterface<nsISupports, nsWrapperCache>
> > (aDestination=0xffffffffffff9e98, aSource=0>
>
> Having aSource nullptr here is a clear no-go.
>
> But:
>
> > (gdb) bt
> > #0  0x000000004cb09ec4 in CallQueryInterface<nsISupports,
> > nsWrapperCache> (aDestination=0xffffffffffff9e98, aSour>
> >     at /usr/pkgsrc/www/firefox52/work/build/dist/include/nsISupportsUtils.h:135
> > #1  xpcObjectHelper::xpcObjectHelper (this=0xffffffffffff9e80,
> > aObject=0x410ed748 <__stack_chk_guard>, aCache=0x0)
> >     at /usr/pkgsrc/www/firefox52/work/firefox-52.9.0esr/js/xpconnect/src/xpcObjectHelper.h:35
>
> .. I don't understand how it can happen with aObject=0x410ed748 and the
> only way to invoke CallQueryInterface being:
>
>             if (aObject)
>                 CallQueryInterface(aObject, &mCache);
>
> (and &mCache looks ok as aDestination=0xffffffffffff9e98 in frame #0
> with this=0xffffffffffff9e80 in frame #1).
>
> So: no idea what is happening here.
>
> Martin

So i did extensive testing by building complete pkgsrc release and on
top their firefox52 package to spot the release where it begins to
fail.
This is the result:

2022Q4 -> crashes
2022Q3 -> untested
2022Q2 -> untested
2022Q1 -> crashes
2021Q4 -> crashes
2021Q3 -> working
2021Q2 -> untested
2021Q1 -> working
2020Q4 -> working

It seems the failure got introduced between 2021Q3 and 2021Q4.
But i cant really spot a difference between firefox52 pkgrevision 39
of 2021Q3 and pkgrevision 41 of 2021Q4.

So i suspect the dependencies of firefox52 to possibly be the cause if
no one else has a better idea.
I will begin to downgrade the dependencies in 2021Q4 to those of
2021Q3 and test if a certain change makes firefox52 working again.

Regards,
Connor