Re: Firefox52 broken on NetBSD9.3 / pkgsrc-2022Q4

David Brownlee <[email protected]> Wed, 22 Mar 2023 19:12:31 +0000

Newsgroups	gmane.os.netbsd.ports.sparc64
Message-ID	<CAGN_6pYZMQR0-ud5svU0Sc44C2B-Wk8ASqyNbCkEQfnodS7+yA@mail.gmail.com>

On Tue, 21 Mar 2023 at 23:22, Connor McLaughlan <[email protected]> wrote:
>
> Hello David,
>
> i have seen your comment and patch for firefox52 and that you put it
> AFTER the include of bsd.prefs.mk, but it needs to be set BEFORE
> bsd.prefs.mk is included.
>
> As stated on this page in the "disabling"-sections:
> https://www.netbsd.org/docs/pkgsrc/hardening.html#hardening.caveats.pie
>
> I set the option directly before the include line of bsd.prefs.mk...so
> unsure if your patch will work as expected.

/me slaps head

Gah - I put it after bsd.prefs.mk so I could use MACHINE_PLATFORM, but I've
switched it to MACHINE_ARCH and after bsd.prefs.mk.

(Verified by running "make show-var VARNAME=_PKGSRC_USE_SSP" this time :)

Thanks for the catch

David