Re: Removing __BROKEN_CONFIG_UNIT_USAGE

Quentin Garnier <[email protected]> Tue, 17 Jul 2007 17:47:06 +0200
Newsgroups gmane.os.netbsd.ports.sun3,gmane.os.netbsd.devel.kernel
Message-ID <[email protected]>
On Tue, Jul 17, 2007 at 06:37:42PM +0900, Izumi Tsutsui wrote:
> [email protected] wrote:
> 
> > > A quick grep through sun3 configs shows vme only ever has wired instances,
> > > so it would seem it's not broken in the __BROKEN_CONFIG_UNIT_USAGE sense.
> > 
> > Exactly.
> > 
> > Yes, sun3 still relies on cf_unit to carry information, but it's not
> > alone in that respect.  As long as that kind of abuse is limited to
> > wired instances, it's ok.
> 
> Hmm, in sun3 vme.c cf_unit is tied to vme_info[] array which specifies
> VME bus type (width) so I thought it was invalid, but if it's still
> valid it is just my ignorance of autoconf(9) and there is no problem.

It's questionable style, but it's not tied to __BROKEN_CONFIG_UNIT_USAGE
because the latter deals with starred instances where the unit number
has a meaning.  The vme instances found in the sun3 config files are all
wired down.

-- 
Quentin Garnier - [email protected] - [email protected]
"You could have made it, spitting out benchmarks
Owe it to yourself not to fail"
Amplifico, Spitting Out Benchmarks, Hometakes Vol. 2, 2005.
signature.asc (application/pgp-signature, 478 B)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (NetBSD)

iQEVAwUBRpzketgoQloHrPnoAQKp2Af/UUEj280PfSa85Vk/57akb+vLH6TDTxDH
pWBQ929qv4J08wLxw5tyb3UKEyN8slcHRP0WD4xW8Fz0dFU6aLEJyriDrXXPitcF
CcqajjJKvnrztLPfZQKOdr9bxXVxUYFpTf3pkil2lg9GyC3hRFnse3AB18PCwKUY
DBz1ff+EDTYdFDTDzjB+erBDVSYcWN8BqKOSrwrKXU1Vbuyf7KigVg7CdPrcuiHj
u3unUgXcZgbzcUAZEF60cLERBJEXhOPgWkgYsU2xIlO+OUtA4ejS9Qvj7Byu8VQ7
8FgF18NVA7udfUkA8R9mjq3wMRhV7n+3fuiHyPlT63YrlUtooBXd+Q==
=AYwV
-----END PGP SIGNATURE-----