Re: __BROKEN_CONFIG_UNIT_USAGE ?

On Dec 1, 2009, at 12:46 PM, David Young wrote:

> On Tue, Dec 01, 2009 at 09:44:29PM +0100, Manuel Bouyer wrote:
>> On Mon, Nov 30, 2009 at 01:54:13PM -0600, David Young wrote:
>>> Only NetBSD/sun3 uses __BROKEN_CONFIG_UNIT_USAGE.  The name of this
>>> mysterious #define, which affects which code in subr_autoconf.c is
>>> compiled, implies that sun3 is somehow "broken"?  Will somebody fix it?
>> 
>> So you know what is broken exactly ?
> 
> No, I do not.  I'm hoping that some NetBSD/sun3 developer knows.

The code makes assumptions about the behavior / relationships of devices at fixed unit numbers.  See sun3/sun3/vme.c:vme_match(), and to a lesser extent, sun3/dev/xd.c:xdmatch() and sun3/dev/xy.c:xymatch().

In general, any use of cfdata_t::cf_unit outside of printing it is wrong (or, at least, discouraged).

It would be good if the sun3 port was switched to the MI VME and Xylogics SMD drivers.

-- thorpej