Re: (maybe) crash your VAX from userspace

On Sat, Mar 23, 2024 at 07:43:54PM +1100, matthew green wrote:
> simple problem: ifp->if_init callback is NULL, leading to
> an attempt to jump to 0 which faults.
> 
>    https://www.netbsd.org/~mrg/if_qe.if_init.diff
> 
> repeated below, it's not big.  i can now run:
> 
>   ifconfig qe0 mtu 512
> 
> 
> .mrg.
> 
> 
> vax/qe(4): supply an ipf->if_init() so that if_init() doesn't crash.
> 
> convert the existing qeinit() to one compatible with if_init.
> 
> 
> Index: if_qe.c
> ===================================================================
> RCS file: /cvsroot/src/sys/dev/qbus/if_qe.c,v
> retrieving revision 1.81
> diff -p -u -r1.81 if_qe.c
> --- if_qe.c	28 May 2019 07:41:49 -0000	1.81
> +++ if_qe.c	23 Mar 2024 08:37:43 -0000
> @@ -97,7 +97,7 @@ struct	qe_softc {

Thanks for the patch. I'll set up a build environment to rebuild
the kernel with that and test it.

Could you please attach it to the PR? I've added a pointer to your
mail with it, but having the patch in there directly would be better
IMHO. It is pr/58068.

Kind regards,
           Alex.
-- 
"Opportunity is missed by most people because it is dressed in overalls and
 looks like work."                                      -- Thomas A. Edison