Re: VAX: Another small GAS bug?

Jan-Benedict Glaw <[email protected]>
Newsgroups gmane.os.netbsd.ports.vax
Message-ID <[email protected]>
On Sun, 2024-04-07 08:04:17 +0200, Jan-Benedict Glaw <[email protected]> wrote:
> On Sun, 2024-04-07 15:22:42 +1000, Kalvis Duckmanton <[email protected]> wrote:
> > diff --git a/sys/arch/vax/vax/unimpl_emul.S b/sys/arch/vax/vax/unimpl_emul.S
> > index c3b7b83baa3a..a546ceda3e2b 100644
> > --- a/sys/arch/vax/vax/unimpl_emul.S
> > +++ b/sys/arch/vax/vax/unimpl_emul.S
> > @@ -683,7 +683,7 @@ emodd:      bsbw    touser
> >          * there aren't any bits left for the fraction.  Therefore we're
> >          * done here;  TMPFRAC1 is equal to TMPFRACTGT and TMPFRAC2 is 0.
> >          */
> > -       movq $0f0.0, TMPFRAC2
> > +       movq $0d0.0, TMPFRAC2
> >         jmp 9f          /* we're done, move on */
> >  1:
> >         /*
> > @@ -727,7 +727,7 @@ emodd:      bsbw    touser
> >          * We are less than 1.0; TMPFRAC1 should be 0, and TMPFRAC2 should
> >          * be equal to TMPFRACTGT.
> >          */
> > -       movd $0f0.0, TMPFRAC1
> > +       movd $0d0.0, TMPFRAC1
> >         movd TMPFRACTGT, TMPFRAC2
> >  9:
> >         /*
> > @@ -763,7 +763,7 @@ zeroexit:
> >         bsbw getaddr_byte
> >         movl $0x0, (%r0)
> >         bsbw getaddr_byte
> > -       movd $0f0, (%r0)
> > +       movd $0d0, (%r0)
> >         brw goback
> > 
> > 
> That is IMHO the exact correct thing to do. Who can commit that?

And I think that's a real bugfix, so maybe pullup to supported
releases as well?

MfG, JBG

--
signature.asc (application/pgp-signature, 195 B)
-----BEGIN PGP SIGNATURE-----

iFwEABECAB0WIQQlDTvPcScNjKREqWEdvV51g5nhuwUCZhJJ9wAKCRAdvV51g5nh
u7dqAJdPPJ48336bPK2qmHpj6AVqrDy2AJ4+zueqLLzXfnZPhqSK7cUlMyQADQ==
=PSdP
-----END PGP SIGNATURE-----
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.