Re: UHCI patch

"François Revol" <[email protected]> Mon, 28 May 2007 14:59:09 +0200 CEST
Newsgroups gmane.os.openbeos.kernel.devel
Message-ID <1429548625-BeMail@laptop>
> > Hi,
> > 
> > I've attached a patch, that has already been reviewed by Michael 
> > Lotz.
> > It's a simple patch that adds some macro to improve readability of 
> > the
> > code, plus some fixes about portability. A method that should 
> > handle 
> > the
> > isochronous transfer is also added, but not implemented yet.
> > 
> 
> Commited.
> Don't you have svn access already ?

Sorry but those changes are not more portable. Breaks things here.

-	addr_t	link_phy;		// Link to the next TD/QH
+	uint32	link_phy;		// Link to the next TD/QH
...

Either change types of funcs using them (or cast) or don't change them 
at all.
Are you sure it's what you want ? (32 bit physical PCI address ?)

François.

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/