Re: UHCI patch

"Salvatore Benedetto" <[email protected]> Mon, 28 May 2007 16:00:30 +0200
Newsgroups gmane.os.openbeos.kernel.devel
Message-ID <[email protected]>
On 5/28/07, François Revol <[email protected]> wrote:
>
> > > Hi,
> > >
> >
> > Commited.
> > Don't you have svn access already ?


Not yet.

Sorry but those changes are not more portable. Breaks things here.
>
> -       addr_t  link_phy;               // Link to the next TD/QH
> +       uint32  link_phy;               // Link to the next TD/QH
> ...
>
> Either change types of funcs using them (or cast) or don't change them
> at all.
> Are you sure it's what you want ? (32 bit physical PCI address ?)


Yes.  That field has to be a 32bit variable, like the others. I'm pretty
sure I checked
all the code that use that variable to see if casted was needed. I'll double
check again
later.

François.


Salvo

-------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> Open-beos-kernel-devel mailing list
> Open-beos-kernel-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/open-beos-kernel-devel
>



-- 
Salvatore Benedetto (a.k.a. emitrax)
Student of Computer and Telecommunications Engineering
University of Messina (Italy)
www.messinalug.org

skype:emitrax
icq:299985329

No to global warming!
http://www.climatecrisis.net/
http://www.stopglobalwarming.org/

Siti di vera informazione Italiana
www.beppegrillo.it

Please do not send me any word, excel or power point file
http://www.gnu.org/philosophy/no-word-attachments.html

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

_______________________________________________
Open-beos-kernel-devel mailing list
Open-beos-kernel-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/open-beos-kernel-devel