Re: UHCI patch

"Salvatore Benedetto" <[email protected]> wrote:
> Here is the line fixed.

While I'm not that familiar with USB, I don't like that change too 
much:

-	void	*buffer_phy;	// A pointer to the buffer with the actual 
packet
+	uint32	buffer_phy;		// A pointer to the buffer with the actual 
packet
[...]
-	if (fStack->AllocateChunk(&result->buffer_log, &result->buffer_phy,
+	if (fStack->AllocateChunk(&result->buffer_log, (void**)&result->
buffer_phy,

AlllocateChunk() needs a void** - and since this change is only of 
interest on 64 bit platforms, it should at least work there, but it 
doesn't, since void* is 64 bit then, while uint32 is not.

Bye,
   Axel.


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/