Re: DiskDeviceManager current status

Hi Jan,

jan matejek <matejcik-IaeKGDb/[email protected]> wrote:
> what to say ...
> Patch is against the latest revision, it includes a documentation
> directory, docs/user/partitioning, with more details (and some
> installation instructions and overviews, for the purpose of our 
> school
> project). The documentation -can- be generated by running doxygen,
> global Doxyfile is supplied, but I don't recommend that, doxygening 
> the
> whole haiku tree takes more than twice the time you'd expect (unless 
> you
> did it before, then your expectation could be accurate).

Great, thanks!

> Let's see what you think about that. Status of the work is described 
> in
> previous mail, I'm going to make some more changes and build a better
> client app. If you find any other obvious flaws, please let me know.

I think it would have been nice if you had started to commit something 
earlier, so that we could have ironed out some things while you were 
writing all of that code :-)
I've only briefly reviewed it (I leave the deeper one to Ingo :)), but 
apart from numerous coding style violations, I only noticed frequently 
missing checks if an allocation succeeded or not. In the kernel you 
always have to check if an allocation succeeded or not; it will have to 
run stable even in low memory situations.

Bye,
   Axel.


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/