Re: Disk Device Manager quo vadis?

Ingo Weinhold napsal(a):
> First of all, it's great you continued with the project! I was afraid you 
> dropped the ball. A little more proactive communication would have been 
> much appreciated. Anyway, thanks a lot for you work.
>   
um ... the thing is, we ended up doing most of the work over one long 
weekend, so we didn't really have time to communicate with you. sorry 
about that.
(but ... well, i told you so in the beginning ;e) )

>> In other news, i am now sick and in bed, so i have about a week's worth
>> of free time. I could try and find out if i can build a gui partitioning
>> client in that time.
>>     
>
> That would of course be nice, but don't sweat it. Rather get well. :-)
>   

i've done a little bit of something, i'll clean it up a little and post 
it here or on haiku-development (as it isn't really kernel related, and 
i am trying to solving some usability problems)

> I had a first look through the patch. As our coding style police already 
> mentioned, there are some incompatibilities with our coding style. I will 
> clean that up while committing the code.
>   
i wonder, what kind of incompatibilities? we mostly tried to adhere to 
the coding style, i'd like to know what went wrong.
(i know about problems in the client app, but we thought the kernel is 
"clean")

> Some files are missing copyright headers, other contain "Copyright: See 
> COPYING file that comes with this distribution", which, I assume, means the 
> MIT license we use for the project. I'd like to add/change the copyright 
> headers so that they comply with our standard header. It would be nice, if 
> you could tell me who was responsible for implementing which part, so that 
> I can credit the authorship appropriately, where things are unclear.
>   
Tomáš Kučera (Tomas Kucera) is exclusively responsible for the 
partitioning add-on. He also documented the addon interface class in 
DiskDeviceManager
Luboš Kulič (Lubos Kulic) is the author of new jobs and the client app.
i, Jan Matějek (Jan Matejek), did the rest - necessary changes in 
DiskDeviceManager and related classes, tinkering with new and existing 
jobs, overview documentation.

> I'd also like to add you guys to the contributors list in our AboutSystem 
> application, unless you object, of course.
>   
i don't have any problem with that. i'll ask my colleagues but i doubt 
they would object

> Apart from that, I've seen some issues in the DDM (jobs) code, that I'd 
> like to solve differently. I'll have to re-familiarize myself with the DDM 
> and look into the patch more thouroughly first, though.
>   
please let me know about that, i am still working on it (as i wrote, 
there are things still missing)

> I will commit things in smaller chunks over the next days -- I'll see when 
> I find time. If you want me to refrain from adjusting the coding style of 
> the partitioning app, so you don't get unnecessary conflicts while you're 
> working on it, I can as well commit it verbatim for the time being.
>   
i am dropping the existing application entirely, as it is no good, and 
starting from scratch. maybe it isn't necessary to commit the existing 
code at all.

regards,
m.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
Open-beos-kernel-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/open-beos-kernel-devel