Re: printkit source related reorganization
julun <[email protected]> Tue, 22 Jul 2008 22:45:18 +0200
| Newsgroups | gmane.os.openbeos.printing |
|---|---|
| Message-ID | <[email protected]> |
Hi all, Michael Pfeiffer schrieb: > Hi Karsten! > > Am 21.07.2008 um 16:03 schrieb Julun: > > ...snipped... > >> What do you think? > > > Please do as you have proposed. Maybe you can also merge the various > *Utils* header and source files into a single header and source file; or > into UI and non-UI related files? > > I had not time to check dependencies between the source files. When you > do the refactoring please try to break existing cyclic dependencies and > avoid new ones :-) > If it it makes sense you could also try to separate between > functionality that concerns printer drivers, printer transport add-ons, > print_server, the preferences application and common printing related > things. > > Moving libprint into src/libs/print sounds good, as long as it does not > have any dependencies to internal API. This way printer driver > developers could use it and would not depend on the internal API that > could change in the future. Or maybe my assumption is wrong that > src/libs is a place for 3rd party libraries only. > > @Jovan: Please let us know if you have code that needs to be committed > before the refactoring can take place. I've integrated my changes as of r25561. I double checked that everything builds so far, please let me know if i missed something to move etc... Next will be to merge the various utils and remove some deps from libprint on private stuff, like MarginView, HWindow and so on. I plan to move that into libprint as well. Regards, Karsten