DiskDevice API 2.3 remarks

"Ingo Weinhold" <bonefish-CFLBMwTPW48UNGrzBIF7/[email protected]>
Newsgroups gmane.os.openbeos.storage
Message-ID <31219700021-BeMail@graete>
Howdy,

while looking a bit more through the headers I found some more details, 
I want to `complain' about. ;-) I hope, I don't warm up too many 
things, we've already discussed. In case I do, please accept my 
apology. I'm an old man and my memory isn't what it used to be. ;-)

* uint8 BDiskDeviceJob::Progress() const;
I would love to see a float return value. I'd say, the most natural 
range for it was [0, 1], but as BStatusBar's max value defaults to 100, 
I could live with that, too. The same goes for 
B_DISK_DEVICE_JOB_SIMPLE_PROGRESS, of course.

* BPartition::SetParameters():
It should read `const char *contentParameters'.

* BPartition::ValidateInitialize():
Why is it gone? Perhaps there was a reason, but I can't remember. 
BDiskSystem::ValidateInitialize() is still there, though. If the method 
was removed by accident and we want to have both, then they should have 
a `const char *parameters' argument (that would be content parameters, 
of course).

* Would BDiskSystem::ValidateSet{Child}Parameters() make sense?

CU, Ingo
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.