Re: two openrsync caveats

dzwdz <[email protected]> writes:

> Hi,
> I've found two weird things about openrsync that I thought I'd report:
>
> First off, openrsync defaults to running (upstream) "rsync" for the
> other end of the connection, even for local copies!  When upstream rsync
> isn't installed (for example, if you're on a stock OpenBSD install), it
> dies with a cryptic error message:

For this issue, I get good results with the following patch (but I don't
know if its the correct way to do it):

Index: main.c
===================================================================
RCS file: /cvs/src/usr.bin/rsync/main.c,v
diff -u -p -r1.73 main.c
--- main.c	29 May 2025 17:03:43 -0000	1.73
+++ main.c	6 Jun 2026 16:00:23 -0000
@@ -625,6 +625,8 @@ basedir:
 		if (dup2(fds[1], STDOUT_FILENO) == -1)
 			err(ERR_IPC, "dup2");
 		execvp(args[0], args);
+		/* Maybe try a hardcoded openrsync. */
+		execvp("/usr/bin/openrsync", args);
 		_exit(ERR_IPC);
 		/* NOTREACHED */
 	default:


-- 
Manuel Giraud