Re: CVS: cvs.openbsd.org: ports

Stuart Henderson <[email protected]>
Newsgroups gmane.os.openbsd.ports.cvs
Message-ID <[email protected]>
On 2026/08/17 05:52, Kurt Mosiejczuk wrote:
> On Mon, Aug 10, 2026 at 04:41:03AM -0600, Stuart Henderson wrote:
> > CVSROOT:	/cvs
> > Module name:	ports
> > Changes by:	[email protected]	2026/08/10 04:41:03
> 
> > Modified files:
> > 	devel/libiscsi : Makefile distinfo 
> > 	devel/libiscsi/pkg: PLIST 
> 
> > Log message:
> > update to libiscsi-1.20.3pl20260809, from Brad (maintainer)
> > fixes various memory-safety bugs etc, add cmake build
> 
> This breaks the build on sparc64. Seems to break disabling of gnutls.

This is because ports-gcc includes /usr/local/include in the header
search path and /usr/local/lib in the library search path (base
toolchain doesn't do this).

Index: Makefile
===================================================================
RCS file: /cvs/ports/devel/libiscsi/Makefile,v
diff -u -p -r1.11 Makefile
--- Makefile	10 Aug 2026 10:41:03 -0000	1.11
+++ Makefile	17 Aug 2026 10:20:02 -0000
@@ -1,6 +1,7 @@
 COMMENT=	client-side library to implement the iSCSI protocol
 
 DISTNAME=	libiscsi-1.20.3pl20260809
+REVISION=	0
 GH_ACCOUNT=	sahlberg
 GH_PROJECT=	libiscsi
 GH_COMMIT=	1985697419d25a62a04e7454ca8185b854b66ad3
@@ -21,11 +22,18 @@ COMPILER_LANGS=	c
 
 WANTLIB=	c pthread
 
-MODULES+=	devel/cmake
+MODULES=	devel/cmake
 
-CONFIGURE_ARGS+=	-DENABLE_WERROR=Off \
-			-DWITH_GNUTLS=No \
-			-DWITH_LIBGCRYPT=No
+# for consistency between base-clang and ports-gcc
+CFLAGS +=	-I/usr/local/include
+MODCMAKE_LDFLAGS= -L/usr/local/lib
+
+# WITH_xxx flags use case-sensitive 'STREQUAL "no"'
+# test-tool needs cunit at build time and installs an extra program
+CONFIGURE_ARGS=	-DENABLE_TEST_TOOL=Off \
+		-DENABLE_WERROR=Off \
+		-DWITH_GNUTLS=no \
+		-DWITH_LIBGCRYPT=no \
 
 NO_TEST=	Yes
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.