Re: CVS: cvs.openbsd.org: ports

Brad Smith <[email protected]>
Newsgroups gmane.os.openbsd.ports.cvs
Message-ID <[email protected]>
On Mon, Aug 17, 2026 at 05:52:20AM -0400, Kurt Mosiejczuk wrote:
> On Mon, Aug 10, 2026 at 04:41:03AM -0600, Stuart Henderson wrote:
> > CVSROOT:	/cvs
> > Module name:	ports
> > Changes by:	[email protected]	2026/08/10 04:41:03
> 
> > Modified files:
> > 	devel/libiscsi : Makefile distinfo 
> > 	devel/libiscsi/pkg: PLIST 
> 
> > Log message:
> > update to libiscsi-1.20.3pl20260809, from Brad (maintainer)
> > fixes various memory-safety bugs etc, add cmake build
> 
> This breaks the build on sparc64. Seems to break disabling of gnutls.
> 
> [5/63] /usr/obj/ports/libiscsi-1.20.3pl20260809/bin/cc -DHAVE_CONFIG_H -I/usr/obj/ports/libiscsi-1.20.3pl20260809/build-sparc64 -I/usr/obj/ports/libiscsi-1.20.3pl20260809/libiscsi-1985697419d25a62a04e7454ca8185b854b66ad3/include -O2 -pipe -DNDEBUG -fPIC -Wall -W -Wshadow -Wstrict-prototypes -Wpointer-arith -Wcast-align -Wcast-qual -Wvla -Wno-unknown-warning-option -Wno-stringop-truncation -Wno-unused-parameter -Wwrite-strings -MD -MT lib/CMakeFiles/iscsi_objects.dir/login.c.o -MF lib/CMakeFiles/iscsi_objects.dir/login.c.o.d -o lib/CMakeFiles/iscsi_objects.dir/login.c.o -c /usr/obj/ports/libiscsi-1.20.3pl20260809/libiscsi-1985697419d25a62a04e7454ca8185b854b66ad3/lib/login.c
> FAILED: lib/CMakeFiles/iscsi_objects.dir/login.c.o
> /usr/obj/ports/libiscsi-1.20.3pl20260809/bin/cc -DHAVE_CONFIG_H -I/usr/obj/ports/libiscsi-1.20.3pl20260809/build-sparc64 -I/usr/obj/ports/libiscsi-1.20.3pl20260809/libiscsi-1985697419d25a62a04e7454ca8185b854b66ad3/include -O2 -pipe -DNDEBUG -fPIC -Wall -W -Wshadow -Wstrict-prototypes -Wpointer-arith -Wcast-align -Wcast-qual -Wvla -Wno-unknown-warning-option -Wno-stringop-truncation -Wno-unused-parameter -Wwrite-strings -MD -MT lib/CMakeFiles/iscsi_objects.dir/login.c.o -MF lib/CMakeFiles/iscsi_objects.dir/login.c.o.d -o lib/CMakeFiles/iscsi_objects.dir/login.c.o -c /usr/obj/ports/libiscsi-1.20.3pl20260809/libiscsi-1985697419d25a62a04e7454ca8185b854b66ad3/lib/login.c
> /usr/obj/ports/libiscsi-1.20.3pl20260809/libiscsi-1985697419d25a62a04e7454ca8185b854b66ad3/lib/login.c:51:10: fatal error: gnutls/crypto.h: No such file or directory
>    51 | #include <gnutls/crypto.h>
>       |          ^~~~~~~~~~~~~~~~~
> compilation terminated.

I didn't know these options were case sensitive. This should
fix things and have the intended result.


Index: Makefile
===================================================================
RCS file: /cvs/ports/devel/libiscsi/Makefile,v
retrieving revision 1.11
diff -u -p -u -p -r1.11 Makefile
--- Makefile	10 Aug 2026 10:41:03 -0000	1.11
+++ Makefile	17 Aug 2026 21:15:47 -0000
@@ -4,6 +4,7 @@ DISTNAME=	libiscsi-1.20.3pl20260809
 GH_ACCOUNT=	sahlberg
 GH_PROJECT=	libiscsi
 GH_COMMIT=	1985697419d25a62a04e7454ca8185b854b66ad3
+REVISION=	0
 CATEGORIES=	devel net
 
 SHARED_LIBS=	iscsi	2.2
@@ -23,9 +24,9 @@ WANTLIB=	c pthread
 
 MODULES+=	devel/cmake
 
-CONFIGURE_ARGS+=	-DENABLE_WERROR=Off \
-			-DWITH_GNUTLS=No \
-			-DWITH_LIBGCRYPT=No
+CONFIGURE_ARGS+=	-DENABLE_WERROR=OFF \
+			-DWITH_GNUTLS=no \
+			-DWITH_LIBGCRYPT=no
 
 NO_TEST=	Yes
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.