Re: sun4c audio in 4.5
Alexandre Ratchov <[email protected]>
| Newsgroups | gmane.os.openbsd.sparc |
|---|---|
| Message-ID | <[email protected]> |
On Sun, May 17, 2009 at 12:21:05AM +0000, Jacob Meuser wrote:
>
> hmm, should we do fp->flags = AUDIO_ENCODING_EMULATED? I guess it's
> kind of pointless since this is the only supported encoding.
>
> if this thing really can do full-duplex, as the driver claims, then it
> should be
>
> if (setmode & AUMODE_PLAY) {
> ...
> }
> if (setmode & AUMODE_RECORD) {
> ...
> }
>
> right?
>
yes. The ``else'' should bee removed, and the
AUDIO_ENCODING_EMULATED should be set.
> the rest looks good to me.
>
> interesting that the driver wasn't doing anything with recording
> parameters before ... makes me wonder if recording ever really worked.
>
that's what i wondered too, when i saw the code.
-- Alexandre