Re: small set of qwx bug fixes
Greg Steuck <[email protected]>
| Newsgroups | gmane.os.openbsd.tech |
|---|---|
| Message-ID | <[email protected]> |
Stefan Sperling <[email protected]> writes: > Two more fixes on top: > > 1. Do not zero the entire qwx sc->hal structure during resume. > The structure contains pointers to DMA allocations which are leaked and > replaced by new allocations during resume if we zero the entire structure. > At attach time, the structure comes pre-zeroed so an initial memset is > not needed either. > > 2. Do not attempt to clean up Tx rings which are uninitialized. > Fixes a crash, seen by jmc@ and reproduced by me, when "qrtr init" times out. Between this diff and the one before I went from qwx ~unusable across resume in -current to ~reliable. I got bored after 16 wakeups and the running ping recovering with no manual intervention. Ship it! Thanks Greg