pfctl -s all should not print operating system fingerprints

Alexandr Nedvedicky <[email protected]>
Newsgroups gmane.os.openbsd.tech
Message-ID <[email protected]>
Hello tech@,

'pfctl -s all' shows also all OS fingerprints loaded
to kernel, while it should report only the number of
fingerprints. This is a regression in 7.9 I've accidentally
introduced.

the issue has been noticed and reported by David Adams on bugs [1].

The same diff I've posted to bugs@ few weeks ago is found further
below.

OK to commit?

thanks and
regards
sashan

[1] https://marc.info/?l=openbsd-bugs&m=178134388987868&w=2

--------8<---------------8<---------------8<------------------8<--------
diff --git a/sbin/pfctl/pfctl.c b/sbin/pfctl/pfctl.c
index a38583a9f13..786175d6fa9 100644
--- a/sbin/pfctl/pfctl.c
+++ b/sbin/pfctl/pfctl.c
@@ -3339,6 +3339,7 @@ main(int argc, char *argv[])
 		pfctl_show_limits(dev, opts);
 		break;
 	case SHOWOPT_ALL:
+		opts |= PF_OPT_SHOWALL;
 		pfctl_init_show_rules(&show_rules_pf, dev, opts);
 		pfctl_load_fingerprints(dev, opts);
 		pfctl_show_rules(&show_rules_pf, path, PFCTL_SHOW_RULES,
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.