Re: pcidevs: add SP US75 & Samsung 9100 pro controllers

Jonathan Gray <[email protected]> Tue, 28 Jul 2026 21:01:41 +1000
Newsgroups gmane.os.openbsd.tech
Message-ID <[email protected]>
On Tue, Jul 28, 2026 at 10:11:51AM +0000, Job Snijders wrote:
> On Tue, Jul 28, 2026 at 02:45:25PM +1000, Jonathan Gray wrote:
> > ...
> > 
> > move to after YMTC to be ordered by vendor id
> > 
> > > +product	MAXIO MAP1602		0x1602	MAP1602
> > > +
> > 
> > wrong place in file, not ordered by vendor name
> > 
> > > +product SAMSUNG2 S4LY027_NVME	0xa810	S4LY027
> > 
> > using PM9E1 would be consistent with the other entries
> 
> thanks for the feedback.
> 
> Index: pcidevs
> ===================================================================
> RCS file: /cvs/src/sys/dev/pci/pcidevs,v
> diff -u -p -r1.2143 pcidevs
> --- pcidevs	24 Jul 2026 13:58:18 -0000	1.2143
> +++ pcidevs	28 Jul 2026 10:06:06 -0000
> @@ -356,6 +356,7 @@ vendor	RPI		0x1de4	Raspberry Pi
>  vendor	AMPERE		0x1def	Ampere
>  vendor	KIOXIA		0x1e0f	Kioxia
>  vendor	YMTC		0x1e49	YMTC
> +vendor	MAXIO		0x1e4b	Maxio
>  vendor	SSSTC		0x1e95	SSSTC
>  vendor	QUECTEL		0x1eac	Quectel
>  vendor	TEHUTI		0x1fc9	Tehuti Networks
> @@ -8010,6 +8011,9 @@ product MATROX MYST_G200_SD	0xff02	MGA M
>  product MATROX MILL_G200_SG	0xff03	MGA Millennium G200 SG
>  product MATROX MARV_G200_SD	0xff04	MGA Marvel G200 SD
>  
> +/* Maxio */
> +product	MAXIO MAP1602		0x1602	MAP1602

I'd change the tab after 'product' to a space to match most of the others

ok jsg@

> +
>  /* MediaTek products */
>  product MEDIATEK MT7921K	0x0608	MT7921K
>  product MEDIATEK RZ616		0x0616	RZ616
> @@ -9418,6 +9422,7 @@ product SAMSUNG2 PM9A1_NVME	0xa80a	PM9A1
>  product SAMSUNG2 PM9B1_NVME	0xa80b	PM9B1
>  product SAMSUNG2 PM9C1_NVME	0xa80c	PM9C1
>  product SAMSUNG2 PM9C1A_NVME	0xa80d	PM9C1a
> +product SAMSUNG2 PM9E1_NVME	0xa810	PM9E1
>  product SAMSUNG2 NVME_171X	0xa820	NVMe
>  product SAMSUNG2 NVME_172X	0xa821	NVMe
>  product SAMSUNG2 NVME_172X_A_B	0xa822	NVMe
> 
>