Re: ospfd: rewrite handling of LS_UPD, LS_FLOOD and LS_SNAP in the ospf engine

On Mon, Aug 31, 2026 at 11:35:16AM +0200, Claudio Jeker wrote:
> The code handling LSA updates and flooding in the ospf engine is
> doing a lot more work than needed. Also it fumbles inside of the
> imsg.
> 
> Instead of passing imsg data around pass the lsa cache ref to lsa_flood
> and ls_retrans_list_add. The ref holds all the data needed for those
> calls. lsa_cache_add is also changed to pass an ibuf instead of imsg->data
> and it is more careful at extracting the data. On top of this
> lsa_cache_get becomes unused and is replaced by lsa_cache_ref which is
> used in ls_retrans_list_add to increase the refcount on the lsa_ref.

Reads fine (and much better) to me. I have no setup to test it, though.